AnKiT-GaRG2 commented on PR #9182:
URL: https://github.com/apache/hop/pull/9182#issuecomment-6548286766
Thanks @bamaer, you're right: once any row is a regex, every row goes
through `resolveSheetNamesFromRegex()`, and the exact-name branch added the
name unresolved.
Pushed a fix: the exact-name branch now uses `resolve(sheet.getName())`, as
you suggested. I added `testSheetNameResolvedFromVariableAlongsideRegexRow` (a
non-matching regex row plus a `${SHEET_NAME}` row on `pdi-17765.xlsx`). It
fails with the fix reverted and passes with it. `ExcelInput*Test` passes (25
tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
