bamaer commented on PR #9182:
URL: https://github.com/apache/hop/pull/9182#issuecomment-6540846257
Thanks @AnKiT-GaRG2. Checked locally: `ExcelInput*Test` passes (24 tests),
and the new test fails with the fix reverted.
**Should fix**
- If any sheet row has Regex = Yes, every row goes through
`resolveSheetNamesFromRegex()`. Its exact-name branch still adds
`sheet.getName()` unresolved (`ExcelInput.java:531`). So a configuration with
one regex row and one `${SHEET_NAME}` row (Regex = No) still reads 0 rows from
that sheet; I tested this against `pdi-17765.xlsx`. Suggested fix:
```java
} else {
String exactName = resolve(sheet.getName());
logBasic("Sheet exact name: [" + exactName + "]");
matchedNames.add(exactName);
```
It would be worth adding a second test for the mixed case next to
`testSheetNameResolvedFromVariable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
