bamaer commented on PR #9183: URL: https://github.com/apache/hop/pull/9183#issuecomment-6540872518
Thanks @AnKiT-GaRG2, this matches how `pull()` already handles it. **Should fix** - `UIGit.fetch()` is also called by the automatic fetch timer (`GitPerspective.fetchAutomatic()`, "Fetch remote changes automatically", every 20 minutes), which runs on the `Git fetch timer` thread rather than the SWT UI thread. With this change an authentication error there reaches `promptUsernamePassword()` / `new ErrorDialog(...)` (`UIGit.java:819-833`). Those throw `SWTException: Invalid thread access`, so the log shows that instead of the authentication error. A background fetch shouldn't open a dialog anyway. Suggest prompting only from the manual Fetch, e.g. a `fetch(boolean promptForCredentials)` overload that the timer calls with `false`. Code reviewed, not built or run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
