AnKiT-GaRG2 commented on PR #9183: URL: https://github.com/apache/hop/pull/9183#issuecomment-6548286445
Thanks @bamaer, good catch. The timer thread would hit `SWTException: Invalid thread access` instead of the authentication error. Pushed f001dc1dde: added `UIGit.fetch(boolean promptForCredentials)`. `fetch()` keeps the old behaviour (calls it with `true`), and `GitPerspective.fetchAutomatic()` now calls `fetch(false)`. With `false`, an authentication failure throws a `HopException` that the timer logs, with no dialog. Only the manual Fetch prompts. The plugin compiles and is formatted with spotless; I have not tested it against a remote that requires credentials. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
