[
https://issues.apache.org/jira/browse/HTRACE-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14340871#comment-14340871
]
Nick Dimiduk commented on HTRACE-119:
-------------------------------------
I agree with [~cmccabe] in principal. In mind of broach compatibility, it think
we need this patch in HTrace AND HBase should fix its double-detach issue.
HBase is designed to run across multiple versions of Hadoop for any given
release, and will (probably) lean on Hadoop to provide the trace version (or
we'll have two entries in the class path at runtime). Better to err on the side
of leniency, especially in the face of multiple released versions in the wild.
It would be interesting if we could we provide a build plugin to detect double
detach at compile time.
> detach of NullScope singleton should not fail
> ---------------------------------------------
>
> Key: HTRACE-119
> URL: https://issues.apache.org/jira/browse/HTRACE-119
> Project: HTrace
> Issue Type: Bug
> Affects Versions: master
> Reporter: Masatake Iwasaki
> Assignee: Masatake Iwasaki
> Attachments: HTRACE-119.001.patch
>
>
> The {{detach}} method of NullScope singleton is possible to be called
> multiple times by users avoiding conditionals by the assumption that
> NullScope#close and NullScope#detach results in no-op. Calling {{detach}} of
> NullScope singleton multiple times throws RuntimeException by HTRACE-101 now.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
