[
https://issues.apache.org/jira/browse/HTRACE-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343622#comment-14343622
]
Colin Patrick McCabe commented on HTRACE-119:
---------------------------------------------
bq. It would be better to override the method in NullScope as you say because
the intension is clearer, though I think 001 and 002 works exactly same way
because TraceScope.span is never to be null if it is not NullScope.
That's true. 001 and 002 work the same way... the only difference is that 002
is a bit clearer (to me, at least).
bq. I think close also should be overriden in NullScope to be consistent. How
about 003 patch I attached?
+1 for patch 003. I'll give it a few hours for others to comment.
thanks again, [~iwasakims]!
> detach of NullScope singleton should not fail
> ---------------------------------------------
>
> Key: HTRACE-119
> URL: https://issues.apache.org/jira/browse/HTRACE-119
> Project: HTrace
> Issue Type: Bug
> Affects Versions: master
> Reporter: Masatake Iwasaki
> Assignee: Masatake Iwasaki
> Attachments: HTRACE-119.001.patch, HTRACE-119.002.patch,
> HTRACE-119.003.patch
>
>
> The {{detach}} method of NullScope singleton is possible to be called
> multiple times by users avoiding conditionals by the assumption that
> NullScope#close and NullScope#detach results in no-op. Calling {{detach}} of
> NullScope singleton multiple times throws RuntimeException by HTRACE-101 now.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
