[ 
https://issues.apache.org/jira/browse/HTRACE-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567845#comment-14567845
 ] 

Masatake Iwasaki commented on HTRACE-174:
-----------------------------------------

Thanks for working on this, [~cmccabe]. There are some nits on applying and 
building.

{{git apply}} failed on owl.png. {{--binary}} option of {{git diff}} might help 
this?
{noformat}
error: cannot apply binary patch to 'htrace-htraced/src/web/image/owl.png' 
without full index line
error: htrace-htraced/src/web/image/owl.png: patch does not apply
{noformat}

RAT check complained about added files.
{noformat}
Unapproved licenses:

  /iwasakims/srcs/htrace/htrace-htraced/src/web/lib/backbone-1.1.2.js
  /iwasakims/srcs/htrace/htrace-htraced/src/web/lib/jquery-2.1.4.js
  /iwasakims/srcs/htrace/htrace-htraced/src/web/lib/underscore-1.7.0.js
{noformat}


> Refactor GUI to fix pagination, form validation, about screen
> -------------------------------------------------------------
>
>                 Key: HTRACE-174
>                 URL: https://issues.apache.org/jira/browse/HTRACE-174
>             Project: HTrace
>          Issue Type: Bug
>    Affects Versions: 3.1.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HTRACE-174.001.patch
>
>
> Refactor the GUI to fix pagination, form validation, and add an about screen.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to