[
https://issues.apache.org/jira/browse/HTRACE-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14579603#comment-14579603
]
Colin Patrick McCabe commented on HTRACE-174:
---------------------------------------------
Thanks for reviewing, [~stack].
bq. Shall we make a dev branch? Then a few of us can hack on this at the one
time.
Hmm. I haven't thought about it that much, but I think it might be easier just
to do this on trunk. We have a stable release out there so people can always
use that if they want something stable. I would love to see more contributors
hacking on this... what I have now is just a start clearly :)
bq. High-level, we need to move this 'go' webapp out of htrace-htraced. It
should be in core or in htrace-webapp? I say this because I can see this webapp
being used by htraced but also I can see it being deployed as WAR under hbase
master. I can work on that.
+1. It would be great to have this work for hbase (and also for Accumulo) so
that we didn't have GUI fragmentation. We talked about two ways of doing
this... 1. is hooking htraced up to hbase, 2. is making the GUI work against
both.
I don't have a strong opinion either way... you guys probably are more aware of
the design tradeoffs of both. Perhaps HBase could have a servelet that
implements the htrace gui REST API? Can you file a separate JIRA to track that
effort? Perhaps we can do it in a few stages, where the first stage is moving
the code to a top-level htrace GUI project. In any case, we probably want to
separate that from these changes (this patch is big enough)
bq. I was going to work on removing the 'About'. I think when you click on
HTrace in far left corner, then you'd get what is currently the about screen
(unless you had other plans for this Colin?) If you agree, I could work on this.
Hmm. The current "about" screen is more of a "server info" screen. Maybe we
can create a separate about screen that really just has some basic info about
htrace (and links to the online docs), the owl logo, and the GUI version (not
server version). Then we can rename the current "about" page to "info"....
then the upper left corner could be the former. what do you think?
bq. nit: is search a good name for the traces panel? Call it Traces? Sure, you
have to search to get some but then once you have a set of traces, you do
digging and exploring... non-search facility. If you agree, I could change this.
Maybe "query" rather than "search"? "Traces" sounds a bit generic (or maybe
it's just me?) Also we'd have a lot of confusing class names :)
bq. The red line is nice. Should have the time run along the top in a little
popup box. If you are amenalble, I could work on this.
Great idea. In general we could use more popups and hover things on the
canvas. We might have to rejigger the widget code a bit to pass through the
{{mousemove}} events to all elements in the bounding box, not just selected
ones.
bq. Similar when you select a trace. Its detail should show on the span in a
popup rather than on the LHS. Perhaps span detail too much for a popup?
I think a popup would be nice, but there has to be some way of getting a
copy/pastable view for programmers. Maybe double-click could create an HTML
popup screen that we could copy and paste from, whereas hover would just
display a box on the canvas.
Let's commit this and open follow-on jiras for the stuff you mentioned... this
is getting fun :)
> Refactor GUI to fix pagination, form validation, about screen
> -------------------------------------------------------------
>
> Key: HTRACE-174
> URL: https://issues.apache.org/jira/browse/HTRACE-174
> Project: HTrace
> Issue Type: Bug
> Affects Versions: 3.1.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-174.001.patch, HTRACE-174.002.patch
>
>
> Refactor the GUI to fix pagination, form validation, and add an about screen.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
