[
https://issues.apache.org/jira/browse/HTRACE-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578183#comment-14578183
]
Colin Patrick McCabe commented on HTRACE-174:
---------------------------------------------
Sorry for the delay on this one. I had a bunch of stuff that I wanted to get
working. Hopefully this latest patch makes it clearer.
I implemented a canvas graphic that shows the search result spans in graphical
format, like we discussed earlier. When you move the cursor on the canvas, it
draws a red vertical line and updates the time indicator on the left side of
the screen, to let you know what time your cursor is hovering over. The begin
and end time are also provided, and can be changed to change the zoom.
Clicking on a span brings up the details for that span in the left tab. This
will make it easy to copy and paste information out of spans, and also to get
more details.
There is a clear button which clears all spans, and a zoom button which zooms
so that all spans are visible.
bq. git apply failed on owl.png. --binary option of git diff might help this?
Good catch. I will use --binary in the future.
bq. RAT check complained about added files.
Let me update the RAT stuff and license attribution stuff.
bq. Any value is not set to span. this.set("spanId", xxx) should be
span\["spanId"\] = xxx
There's actually a reason for this. From
http://stackoverflow.com/questions/8776378/questions-about-the-get-and-set-methods-in-backbone-js
:
bq. The reason is that setting properties doesn't trigger events, whereas
setting values via functions enables it to trigger events that Backbone
requires to function properly.
bq. fomatting is not consistent for "parents".
fixed
The next things to implement here are:
* implementing clicking the "down" button on spans gets the children, clicking
the up button gets the parents
* If spans are selected, clear should clear only those spans. The delete key
should do the same thing.
* If spans are selected, zoom should zoom to a bounding box for those spans
rather than for all spans.
* Control-click selects multiple spans, whereas normal click selects only one
* scrolling
> Refactor GUI to fix pagination, form validation, about screen
> -------------------------------------------------------------
>
> Key: HTRACE-174
> URL: https://issues.apache.org/jira/browse/HTRACE-174
> Project: HTrace
> Issue Type: Bug
> Affects Versions: 3.1.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-174.001.patch
>
>
> Refactor the GUI to fix pagination, form validation, and add an about screen.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
