[
https://issues.apache.org/jira/browse/HTRACE-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274624#comment-15274624
]
Colin Patrick McCabe commented on HTRACE-358:
---------------------------------------------
bq. If we did this, we'd end up implementing the same `wrap` methods twice in
`TraceExecutorService` and `ScheduledTraceExecutorService` and I don't think
that will lead to sustainable code in the future.
I was envisioning doing without this method, and just calling the Tracer#wrap
method directly. However, if you feel that would be too unwieldy, go ahead and
leave the wrap methods in there, as long as they are package-private. We can
always change it later.
bq. Do protected methods show up in the public API? I was unaware of this
previously, but have no problems with doing package-private instead.
The class isn't final, so anyone can subclass it and start depending on these
protected methods. Remember, you should be looking at developers as
adversaries who will try as hard as possible to write code that breaks on a
library version change. And we have to prevent that breakage.
> Provide convenience wrapper around ScheduledExecutorService
> -----------------------------------------------------------
>
> Key: HTRACE-358
> URL: https://issues.apache.org/jira/browse/HTRACE-358
> Project: HTrace
> Issue Type: Improvement
> Components: core
> Affects Versions: 4.1
> Reporter: Mike Drob
> Assignee: Mike Drob
> Attachments: HTRACE-358.patch.txt
>
>
> We already provide a convenience wrapper around {{ExecutorService}}, it would
> not be onerous to also provide a wrapper around {{ScheduledExecutorService}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
