[ 
https://issues.apache.org/jira/browse/HTRACE-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15281750#comment-15281750
 ] 

Colin Patrick McCabe commented on HTRACE-363:
---------------------------------------------

Thanks, [~nisala12].

{code}
+    Assert.assertNotNull(childScope);
+    Assert.assertEquals(childScope.getSpan().getParents().length, 2);
+    Assert.assertEquals(childScope.getSpan().getParents()[1].getHigh(), 100L);
+    Assert.assertEquals(childScope.getSpan().getParents()[1].getLow(), 200L);
{code}
Hmm.  I don't think we should assume that we know which order the parents will 
appear in the parents array.  Maybe sort the array first?

> Add tests for newScope with parent id
> -------------------------------------
>
>                 Key: HTRACE-363
>                 URL: https://issues.apache.org/jira/browse/HTRACE-363
>             Project: HTrace
>          Issue Type: Test
>          Components: core
>            Reporter: Mike Drob
>
> We should add some tests to verify that when there is a currently active 
> scope and `newScope` is called with a valid parent id that both are included 
> in the child span. The current code does this correctly, I think, but we 
> should have tests to prevent accidental regressions in the future.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to