[
https://issues.apache.org/jira/browse/HTRACE-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363093#comment-15363093
]
Colin Patrick McCabe commented on HTRACE-363:
---------------------------------------------
Thanks for the update, [~nisala12]. I attached HTRACE-363.002.patch as a patch
file so that people can see what we're commenting on here. Can you please
close the trace scopes you're opening in these tests? Keeping the thread-local
data around could cause issues with other tests.
> Add tests for newScope with parent id
> -------------------------------------
>
> Key: HTRACE-363
> URL: https://issues.apache.org/jira/browse/HTRACE-363
> Project: HTrace
> Issue Type: Test
> Components: core
> Reporter: Mike Drob
> Assignee: Nisala Mendis
> Attachments: HTRACE-363.002.patch
>
>
> We should add some tests to verify that when there is a currently active
> scope and `newScope` is called with a valid parent id that both are included
> in the child span. The current code does this correctly, I think, but we
> should have tests to prevent accidental regressions in the future.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
