[ 
https://issues.apache.org/jira/browse/HTRACE-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369922#comment-15369922
 ] 

Nisala Mendis commented on HTRACE-363:
--------------------------------------

Hi Colin, 

I have pushed the code related to closing current scope to clear the 
thread-local data. Now all the unit tests should in core package should run 
fine.

Regards
Nisala

> Add tests for newScope with parent id
> -------------------------------------
>
>                 Key: HTRACE-363
>                 URL: https://issues.apache.org/jira/browse/HTRACE-363
>             Project: HTrace
>          Issue Type: Test
>          Components: core
>            Reporter: Mike Drob
>            Assignee: Nisala Mendis
>         Attachments: HTRACE-363.002.patch
>
>
> We should add some tests to verify that when there is a currently active 
> scope and `newScope` is called with a valid parent id that both are included 
> in the child span. The current code does this correctly, I think, but we 
> should have tests to prevent accidental regressions in the future.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to