[ 
https://issues.apache.org/jira/browse/HTRACE-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386369#comment-15386369
 ] 

Colin P. McCabe commented on HTRACE-362:
----------------------------------------

{code}
18        <parent>
19          <artifactId>htrace</artifactId>
20          <groupId>org.apache.htrace</groupId>
21          <version>4.1.0-incubating-SNAPSHOT</version>
22          <relativePath>..</relativePath>
23        </parent>
{code}

Like I wrote in my earlier review, Version 4.1 of HTrace has already been 
released. This should be version 4.2.0-incubating-SNAPSHOT.

{code}
+  <properties>
+    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+    <kudu.version>1.0.0-SNAPSHOT</kudu.version>
+    <hadoop.version>2.6.0-cdh5.4.7</hadoop.version>
+    <createDependencyReducedPom>true</createDependencyReducedPom>
+  </properties>
{code}

See what I wrote earlier in this comment 
https://issues.apache.org/jira/browse/HTRACE-362?focusedCommentId=15333197&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15333197

The KuduHTraceConfiguration file is still there.

I'm not going to look any farther right now since so far, none of my review 
comments from earlier have been addressed.  If you don't want to address a 
review comment, please discuss why.  Please do not Ignore people's review 
comments.  It causes a lot of frustration for people who spend the time to 
review your code.

> Apache KUDU Span receiver implementation for Apache HTrace
> ----------------------------------------------------------
>
>                 Key: HTRACE-362
>                 URL: https://issues.apache.org/jira/browse/HTRACE-362
>             Project: HTrace
>          Issue Type: Bug
>            Reporter: Nisala Mendis
>            Assignee: Nisala Mendis
>         Attachments: HTRACE-362.001.patch, HTRACE-362.002.patch, 
> kudu_span_receiver_basic_design.pdf
>
>
> Implementation should be carried two components as span receiver that writes 
> kudu back end and span viewer to view written span/traces.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to