coderzc commented on code in PR #243:
URL:
https://github.com/apache/incubator-hugegraph-computer/pull/243#discussion_r1201484149
##########
computer-core/src/main/java/org/apache/hugegraph/computer/core/receiver/MessageRecvManager.java:
##########
@@ -214,7 +222,8 @@ public void onStarted(ConnectionId connectionId) {
@Override
public void onFinished(ConnectionId connectionId) {
LOG.debug("ConnectionId {} finished", connectionId);
- this.finishMessagesLatch.countDown();
+ int messageIdx = this.finishMessageCount.getAndIncrement();
Review Comment:
Maybe we should find `finishMessageFuture` through `connectionId`?
##########
computer-core/src/main/java/org/apache/hugegraph/computer/core/sender/MessageSender.java:
##########
@@ -37,4 +39,10 @@ CompletableFuture<Void> send(int workerId, MessageType type)
* @param message message payload
*/
void send(int workerId, QueuedMessage message) throws InterruptedException;
+
+ /**
+ * Invoked when the channel associated with the given connectionId has
+ * an exception is thrown processing message.
+ */
+ void exceptionCaught(TransportException cause, ConnectionId connectionId);
Review Comment:
```suggestion
void transportExceptionCaught(TransportException cause, ConnectionId
connectionId);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
