Radeity commented on PR #243: URL: https://github.com/apache/incubator-hugegraph-computer/pull/243#issuecomment-1558502831
> Maybe we should find finishMessageFuture through connectionId? Hi, @coderzc , during the process of sending vertices and edges, two control message sent from the same worker share the same `ConnectionId`. How about add a boolean variable `sendControlMessage` in `finishSend`: https://github.com/apache/incubator-hugegraph-computer/blob/3328d5232ab944143d60fc4dc946d566550fa6e8/computer-core/src/main/java/org/apache/hugegraph/computer/core/sender/MessageSendManager.java#L161-L171 Only when finish sending edges, we set it true. In this way, we can use `connectionId`, another advantage is both in `inputStep` and `superStep`, we can maintain a future array with same length, cuz `expectedFinishMessages` keeps the same, WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
