Radeity commented on code in PR #243:
URL:
https://github.com/apache/incubator-hugegraph-computer/pull/243#discussion_r1202160042
##########
computer-core/src/main/java/org/apache/hugegraph/computer/core/receiver/MessageRecvManager.java:
##########
@@ -138,35 +150,28 @@ public void onChannelInactive(ConnectionId connectionId) {
@Override
public void exceptionCaught(TransportException cause,
ConnectionId connectionId) {
- // TODO: implement failover
- LOG.warn("Exception caught for connection:{}, root cause:",
+ LOG.error("Exception caught for connection:{}, root cause:",
connectionId, cause);
+ if (this.finishAllMessagesFuture != null) {
+ this.finishAllMessagesFuture.completeExceptionally(cause);
+ }
}
public void waitReceivedAllMessages() {
- try {
- boolean status = this.finishMessagesLatch.await(
- this.waitFinishMessagesTimeout,
+ if (finishAllMessagesFuture != null) {
Review Comment:
This non-null judge is useless, i've already removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
