javeme commented on code in PR #2278:
URL:
https://github.com/apache/incubator-hugegraph/pull/2278#discussion_r1320468556
##########
hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java:
##########
@@ -264,4 +264,36 @@ public static synchronized ServerOptions instance() {
disallowEmpty(),
true
);
+
+ public static final ConfigOption<String> ARTHAS_TELNET_PORT =
+ new ConfigOption<>(
+ "arthas.telnet_port",
+ "arthas provides telnet ports to the outside",
+ disallowEmpty(),
+ "8562"
+ );
+
+ public static final ConfigOption<String> ARTHAS_HTTP_PORT =
+ new ConfigOption<>(
+ "arthas.http_port",
+ "arthas provides http ports to the outside",
+ disallowEmpty(),
+ "8561"
+ );
+
+ public static final ConfigOption<String> ARTHAS_IP =
+ new ConfigOption<>(
+ "arthas.ip",
+ "arthas bound ip",
+ disallowEmpty(),
+ "0.0.0.0"
+ );
+
+ public static final ConfigOption<String> ARTHAS_DISABLED_COMMANDS =
+ new ConfigOption<>(
+ "arthas.disabled_commands",
+ "arthas disabled commands",
+ disallowEmpty(),
+ "jad"
Review Comment:
we can change to choice option here:
https://github.com/apache/incubator-hugegraph/blob/1d0969dedeb693b964cfe7a34d6b7538834e9967/hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java#L63
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
