javeme commented on code in PR #2278:
URL:
https://github.com/apache/incubator-hugegraph/pull/2278#discussion_r1324654748
##########
hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java:
##########
@@ -268,32 +268,32 @@ public static synchronized ServerOptions instance() {
public static final ConfigOption<String> ARTHAS_TELNET_PORT =
new ConfigOption<>(
"arthas.telnet_port",
- "arthas provides telnet ports to the outside",
+ "arthas provides telnet port to the outside",
disallowEmpty(),
"8562"
);
public static final ConfigOption<String> ARTHAS_HTTP_PORT =
new ConfigOption<>(
"arthas.http_port",
- "arthas provides http ports to the outside",
+ "arthas provides http port to the outside",
disallowEmpty(),
"8561"
);
public static final ConfigOption<String> ARTHAS_IP =
new ConfigOption<>(
"arthas.ip",
- "arthas bound ip",
+ "arthas bound ip for access",
disallowEmpty(),
"0.0.0.0"
);
public static final ConfigOption<String> ARTHAS_DISABLED_COMMANDS =
new ConfigOption<>(
"arthas.disabled_commands",
- "arthas disabled commands",
- disallowEmpty(),
+ "arthas disabled commands due to high risk",
+ allowValues("jad"),
Review Comment:
do we allow other commands such as stop/dump? if yes we can revert to `null`
which means allowing any
##########
hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java:
##########
@@ -268,32 +268,32 @@ public static synchronized ServerOptions instance() {
public static final ConfigOption<String> ARTHAS_TELNET_PORT =
new ConfigOption<>(
"arthas.telnet_port",
- "arthas provides telnet ports to the outside",
+ "arthas provides telnet port to the outside",
disallowEmpty(),
"8562"
);
public static final ConfigOption<String> ARTHAS_HTTP_PORT =
new ConfigOption<>(
"arthas.http_port",
- "arthas provides http ports to the outside",
+ "arthas provides http port to the outside",
Review Comment:
prefer `The HTTP port provided by Arthas, it can be accessible from the
outside.`
can we also improve other description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
