imbajin commented on code in PR #2278:
URL:
https://github.com/apache/incubator-hugegraph/pull/2278#discussion_r1328199133
##########
hugegraph-dist/release-docs/licenses/LICENSE-arthas-agent-attach.txt:
##########
Review Comment:
@simon824 do we need attach `ASF2.0` file in our licenses dir? So many
duplicate file (indeed)
##########
hugegraph-api/pom.xml:
##########
@@ -153,6 +153,17 @@
<artifactId>swagger-jaxrs2-jakarta</artifactId>
<version>2.1.9</version>
</dependency>
+
+ <dependency>
+ <groupId>com.taobao.arthas</groupId>
+ <artifactId>arthas-agent-attach</artifactId>
+ <version>3.6.9</version>
+ </dependency>
+ <dependency>
+ <groupId>com.taobao.arthas</groupId>
+ <artifactId>arthas-packaging</artifactId>
+ <version>3.6.9</version>
Review Comment:
same
##########
hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java:
##########
@@ -264,4 +264,36 @@ public static synchronized ServerOptions instance() {
disallowEmpty(),
true
);
+
+ public static final ConfigOption<String> ARTHAS_TELNET_PORT =
+ new ConfigOption<>(
+ "arthas.telnet_port",
+ "The telnet port provided by Arthas, it can be accessible from the
outside.",
+ disallowEmpty(),
+ "8562"
+ );
+
+ public static final ConfigOption<String> ARTHAS_HTTP_PORT =
+ new ConfigOption<>(
+ "arthas.http_port",
+ "The HTTP port provided by Arthas, it can be accessible from the
outside.",
+ disallowEmpty(),
+ "8561"
+ );
+
+ public static final ConfigOption<String> ARTHAS_IP =
+ new ConfigOption<>(
+ "arthas.ip",
+ "The IP provided by Arthas, it can be accessible from the
outside.",
+ disallowEmpty(),
+ "0.0.0.0"
+ );
+
+ public static final ConfigOption<String> ARTHAS_DISABLED_COMMANDS =
+ new ConfigOption<>(
+ "arthas.disabled_commands",
+ "The disabled Arthas commands due to high risk.",
+ null,
+ "jad"
+ );
}
Review Comment:
lack empty line
##########
hugegraph-api/pom.xml:
##########
@@ -153,6 +153,17 @@
<artifactId>swagger-jaxrs2-jakarta</artifactId>
<version>2.1.9</version>
</dependency>
+
+ <dependency>
+ <groupId>com.taobao.arthas</groupId>
+ <artifactId>arthas-agent-attach</artifactId>
+ <version>3.6.9</version>
Review Comment:
1. unify the version with a param like `${arthas.version}`
2. consider use
[3.7.x](https://mvnrepository.com/artifact/com.taobao.arthas/arthas-agent-attach/3.7.1)
after basic test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
