lokidundun commented on code in PR #2982:
URL: https://github.com/apache/hugegraph/pull/2982#discussion_r3109461741


##########
hugegraph-server/hugegraph-rocksdb/src/main/java/org/apache/hugegraph/backend/store/rocksdb/RocksDBTable.java:
##########
@@ -224,7 +224,8 @@ protected BackendColumnIterator 
getById(RocksDBSessions.Session session, Id id)
         return BackendColumnIterator.iterator(col);
     }
 
-    protected BackendColumnIterator getByIds(RocksDBSessions.Session session, 
Set<Id> ids) {
+    protected BackendColumnIterator getByIds(RocksDBSessions.Session session,
+                                             Collection<Id> ids) {

Review Comment:
     Added LinkedHashSet deduplication at the getByIds() entry point while 
preserving input order; skips if Set is already passed. Test updated to verify 
dedup behavior. The      
     backend deduplication does not affect final semantics since 
GraphTransaction reassembles results by the original input order.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to