VGalaxies commented on code in PR #2982:
URL: https://github.com/apache/hugegraph/pull/2982#discussion_r3331568652
##########
hugegraph-server/hugegraph-rocksdb/src/main/java/org/apache/hugegraph/backend/store/rocksdb/RocksDBTable.java:
##########
@@ -215,6 +216,16 @@ protected BackendColumnIterator
queryByIds(RocksDBSessions.Session session,
));
}
+ protected BackendColumnIterator queryByIdsWithGet(RocksDBSessions.Session
session,
+ Collection<Id> ids) {
+ E.checkState(!session.hasChanges(),
Review Comment:
Non-blocking: enabling `queryByIdsWithGet()` for vertex/edge changes
pending-write behavior: any `session.hasChanges()` now throws before even the
single-id path. Please confirm all callers reach this only after
commit/rollback, or keep the old per-id fallback for pending sessions and add a
test through a public query path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
