Copilot commented on code in PR #2982:
URL: https://github.com/apache/hugegraph/pull/2982#discussion_r3328862976
##########
hugegraph-server/hugegraph-rocksdb/src/main/java/org/apache/hugegraph/backend/store/rocksdb/RocksDBTables.java:
##########
@@ -182,8 +182,7 @@ protected BackendColumnIterator
queryById(RocksDBSessions.Session session, Id id
@Override
protected BackendColumnIterator queryByIds(RocksDBSessions.Session
session,
Collection<Id> ids) {
- // TODO: use getByIds() after batch version multi-get is ready
- return super.queryByIds(session, ids);
+ return this.queryByIdsWithGet(session, ids);
}
Review Comment:
The PR description says it will close #2674 (which is about improving
Gremlin ids batch queries to backends like HBase/HStore), but the code changes
in this PR only touch the RocksDB backend. If the intent is to optimize RocksDB
only, the issue reference/"close" statement should be adjusted; otherwise the
optimization likely needs to be implemented in the relevant RPC backends too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
