imbajin commented on PR #3021:
URL: https://github.com/apache/hugegraph/pull/3021#issuecomment-4469382271
The HBase upgrade direction looks reasonable, but I don't think this is
ready to merge until the dependency/release-materials check and HBase runtime
verification are completed.
This PR replaces the old custom `hbase-shaded-endpoint:2.0.6` dependency
with official Apache HBase 2.6.5 artifacts and adds several new/changed
transitive jars in `known-dependencies.txt`:
```text
hugegraph-hbase
-> hbase-endpoint:2.6.5
-> hbase-shaded-client:2.6.5
-> hbase-client/common/zookeeper/protocol/... 2.6.5
-> zookeeper 3.8.6
-> other transitive jars
```
For dependency changes, please also check the release-compliance materials
and update them as needed, following the existing HugeGraph release-docs style:
```text
install-dist/scripts/dependency/known-dependencies.txt
install-dist/release-docs/LICENSE
install-dist/release-docs/NOTICE
install-dist/release-docs/licenses/*
```
This does not necessarily mean adding large new LICENSE / NOTICE sections.
The exact update should be based on the actual newly added or changed jars and
their license/notice requirements, consistent with how this repo already
records third-party dependencies. But we should not merge with only the
dependency allowlist updated if the corresponding release materials still
describe the old HBase 2.0.6 dependency set.
Please also confirm the new HBase 2.6.5 runtime path with enough
verification before merge. Since this PR adds a Dockerized HBase 2.6.5
environment, it would be helpful to include the exact commands/results used to
verify that the new version works end to end, for example:
```text
docker compose -f docker/hbase/docker-compose.hbase.yml build --no-cache
hbase
docker compose -f docker/hbase/docker-compose.hbase.yml up -d
mvn clean install -pl hugegraph-server/hugegraph-hbase -am -DskipTests
init HugeGraph with backend=hbase
start HugeGraph server
run schema + vertex + Gremlin sanity checks
run count/aggregation path that depends on AggregationClient /
LongColumnInterpreter
```
In short:
```text
Before merge:
1. audit the new/changed HBase dependency set
2. update release docs/licenses only where needed
3. confirm the HBase 2.6.5 Docker/runtime verification is actually green
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
