imbajin commented on PR #3021: URL: https://github.com/apache/hugegraph/pull/3021#issuecomment-4505890087
Thanks for addressing the license/notice side of the HBase upgrade. I think we should still try to minimize the new release metadata while staying ASF-compliant. The new HBase runtime jars are indeed bundled, so they should be reflected in the distribution metadata. However, the newly added `LICENSE-hbase-*.txt` files appear to be identical copies of the Apache License 2.0 text. Since the top-level `LICENSE` already includes the full Apache License 2.0 text, I don't think we need to duplicate the same license text once per HBase jar. Could we please narrow this down before merging? TODO: - Keep the new HBase/HBase-thirdparty bundled components listed in `install-dist/release-docs/LICENSE`, including their versions. - Remove the duplicate per-HBase Apache-2.0 license files under `install-dist/release-docs/licenses/`. - Adjust the `LICENSE` wording that currently says each license text is included in `licenses/LICENSE-[project].txt`, since that would no longer be true for these Apache-2.0 entries. - Re-check the added HBase section in `NOTICE` and keep only the upstream notice content that is legally relevant to the bits actually bundled in the HugeGraph distribution. This should satisfy the compliance requirement while avoiding unnecessary license/notice bloat in the release docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
