lokidundun commented on PR #2982: URL: https://github.com/apache/hugegraph/pull/2982#issuecomment-4624043643
> ⚠️ PR 描述里的 `Verifying these changes` 还停留在模板状态： > > ``` > - [ ] Need tests and can be verified as follows: > - xxx > ``` > > 这个 PR 已经来回调整过几轮，最终 scope 也收敛为 RocksDB-only multi-get 优化。建议把验证项补实，至少列出当前新增/应运行的测试，例如： > > ``` > - RocksDB unit: RocksDBTableQueryByIdsTest > - RocksDB core: EdgeCoreTest#testQueryEdgesByNonConsecutiveDuplicateIds > - CI: HugeGraph-Server CI / rocksdb backend > ``` > > 这样后续 reviewer 可以直接确认当前 head 的验证边界，避免继续围绕“是否真的覆盖了最终实现路径”反复确认。 done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
