lokidundun commented on code in PR #2982:
URL: https://github.com/apache/hugegraph/pull/2982#discussion_r3355276758
##########
hugegraph-server/hugegraph-rocksdb/src/main/java/org/apache/hugegraph/backend/store/rocksdb/RocksDBTable.java:
##########
@@ -224,13 +235,15 @@ protected BackendColumnIterator
getById(RocksDBSessions.Session session, Id id)
return BackendColumnIterator.iterator(col);
}
- protected BackendColumnIterator getByIds(RocksDBSessions.Session session,
Set<Id> ids) {
+ protected BackendColumnIterator getByIds(RocksDBSessions.Session session,
+ Collection<Id> ids) {
if (ids.size() == 1) {
return this.getById(session, ids.iterator().next());
}
- List<byte[]> keys = new ArrayList<>(ids.size());
- for (Id id : ids) {
+ Collection<Id> uniqueIds = ids instanceof Set ? ids : new
LinkedHashSet<>(ids);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
