imbajin commented on code in PR #3102:
URL: https://github.com/apache/hugegraph/pull/3102#discussion_r3633214673
##########
hugegraph-server/pom.xml:
##########
@@ -355,6 +347,24 @@
</build>
<profiles>
+ <profile>
+ <id>all-backends</id>
+ <activation>
+ <property>
+ <name>!rocksdb-only</name>
Review Comment:
‼️ **Critical: preserve the existing default test profiles**
This property-activated `all-backends` profile is active whenever
`rocksdb-only` is absent. Maven deactivates an `activeByDefault` profile when
another profile in the same POM activates, so the normal invocation no longer
activates `core-test`; the analogous new profile in `hugegraph-test/pom.xml`
also disables the default `memory` profile. On this exact head, `mvn
help:active-profiles -pl hugegraph-server/hugegraph-test` lists both
`all-backends` profiles but neither `core-test` nor `memory`, while
`-Drocksdb-only` restores them. Ordinary default builds can therefore skip the
established Core Surefire execution and lose the filtered memory backend
configuration. Please restructure the full-backend selection so default builds
retain `core-test` and `memory`, and add a regression check for the default
active-profile/test set.
##########
.github/workflows/docker-build-ci.yml:
##########
@@ -26,6 +30,18 @@ on:
paths:
- '**/Dockerfile*'
- '.dockerignore'
+ - '.github/workflows/docker-build-ci.yml'
+ - 'pom.xml'
+ - 'hugegraph-pd/hg-pd-grpc/pom.xml'
+ - 'hugegraph-server/pom.xml'
+ - 'hugegraph-server/hugegraph-core/pom.xml'
+ - 'hugegraph-server/hugegraph-rocksdb/pom.xml'
Review Comment:
⚠️ **Important: run the architecture smoke for RocksDB source changes**
The new runtime matrix builds and executes the RocksDB/JNI module, but this
path filter matches only its `pom.xml`. A PR that changes
`hugegraph-server/hugegraph-rocksdb/src/**` without touching one of the listed
infrastructure files will not schedule the amd64/arm64/riscv64 smoke, leaving
native-loading and architecture regressions untested. Please cover the module
path (for example, `hugegraph-server/hugegraph-rocksdb/**`) or otherwise add an
equivalent trigger for the runtime code exercised by this job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
