imbajin commented on code in PR #3102:
URL: https://github.com/apache/hugegraph/pull/3102#discussion_r3639489542


##########
hugegraph-server/hugegraph-dist/src/assembly/static/bin/util.sh:
##########
@@ -25,6 +25,45 @@ function command_available() {
     fi
 }
 
+function configure_riscv64_libatomic() {

Review Comment:
   ⚠️ **Important: apply the RISC-V libatomic setup to the store dumper**
   
   This helper is invoked by `hugegraph-server.sh` and `init-store.sh`, but 
`dump-store.sh` still launches `StoreDumper` directly without sourcing 
`util.sh`. `StoreDumper` constructs the graph with `HugeFactory.open(conf)`, so 
a RocksDB-backed dump on RISC-V starts a separate JVM without the `LD_PRELOAD` 
required by this change and can fail at native library loading even though 
server startup succeeds. Please invoke this helper before the dumper JVM (and 
audit any other standalone RocksDB-opening launchers), then cover the 
store-dump path in the native RISC-V smoke test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to