bitflicker64 commented on PR #3132:
URL: https://github.com/apache/hugegraph/pull/3132#issuecomment-5514068084
#3187 makes the entrypoint read the Server start timeout from
`HG_SERVER_STARTUP_TIMEOUT_S` (the default stays 120, from #3186). After it
merges, this chart can set the variable from the same numbers that size the
startup probe, so the two timers cannot disagree. In
`templates/server-deployment.yaml`, in the Server container env:
```yaml
- name: HG_SERVER_STARTUP_TIMEOUT_S
value: {{ mul (include "hugegraph.server.startupFailureThreshold" . | int)
(int .Values.server.probes.startup.periodSeconds) | quote }}
```
With that, the probe owns the startup budget outright: the `-t` timer only
starts after the storage wait, so it can no longer fire first. The 449-second
floor inside `hugegraph.server.startupFailureThreshold` and the "further 120
seconds in the start command" line in the README are both sized around the
fixed 120 and can be revisited in the same change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]