Adarsh-Me commented on PR #3132: URL: https://github.com/apache/hugegraph/pull/3132#issuecomment-5528828385
Context: I picked up #3133 after @bitflicker64 pointed me at it, and his 'what is still open on master' breakdown is what my PR #3192 is built on — so first, thanks. Two notes from working in the same area: - The entrypoint is getting more config surface (my #3192 adds `AUTHENTICATOR_CLASS` and ships `props.awk` next to it). Since this chart templates env/secret wiring into the same entrypoint, it may be worth a rebase check once either merges — the auth path in particular (`PASSWORD` + token secret) is exactly what the chart's server-deployment env block touches. - The `HG_SERVER_STARTUP_TIMEOUT_S` dependency on #3187 above makes the probe/timeout coupling explicit, which seems like the right shape to me — one source of truth for both timers. Is there anything a second pair of hands can help move here — e.g. running the chart against a kind cluster and reporting back, while it waits for @imbajin's review? The live-verification notes in the status comment look thorough, and an independent run would strengthen the case for getting it in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
