imbajin commented on code in PR #3209:
URL: https://github.com/apache/hugegraph/pull/3209#discussion_r4025022419
##########
hugegraph-struct/src/main/java/org/apache/hugegraph/struct/schema/PropertyKey.java:
##########
@@ -424,6 +424,9 @@ public String convert2Groovy(boolean attachIdFlag) {
case UUID:
builder.append(".asUUID()");
break;
+ case DECIMAL:
Review Comment:
⚠️ Blocking: yes. Summary: This makes struct schema generation emit an API
that the struct builder does not expose. Evidence: struct PropertyKey.Builder
has no asDecimal(), and convSingleValue has no DECIMAL
conversion/valueToDecimal; after schema/default JSON values arrive as strings,
validValueOrThrow("1.5") returns null/throws, unlike server PropertyKey.
Requested change: add the struct conversion and builder method, plus
string/numeric/default-value tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
