SebastianGruza commented on PR #3209: URL: https://github.com/apache/hugegraph/pull/3209#issuecomment-5699668520
Thanks for the reviews. All three blocking points are handled in 9d5eaab: the DECIMAL conversion in the struct copy (method, branch in `convSingleValue`, `asDecimal()` on the builder), `serializeWithType` for GraphSON v2/v3 with the `gx:BigDecimal` type id kept, and `OLAP_SECONDARY`/`OLAP_RANGE` rejected for decimals plus a guard in `IndexLabelBuilder.build()`. Four new tests (struct ×2, unit GraphSON, core OLAP), details in the inline threads. Locally on JDK 11: struct 5/5, unit 47/47 for the touched classes, core on rocksdb 384 tests in the four touched classes, 0 failures. On top of that, end to end on live servers (hstore on PD + 3 stores, rocksdb), dists built from `a28554e` and `9d5eaab`: 37 checks (schema, no-index rule, OLAP, REST with batch `SUM` and a default value, Gremlin through the REST proxy and straight on gremlin-server in GraphSON v2/v3), before 24 pass / 9 fail, after 33 pass / 0 fail on both backends; script `cluster/decimal_e2e.py`, logs `results/decimal/e2e/`, write-up in `docs/decimal-datatype.md` in https://github.com/SebastianGruza/hugegraph-validation. One thing for the release notes rather than for this PR: a graph that already contains a DECIMAL property key cannot be opened by a server without this change (`No enum constant DataType.DECIMAL` at startup). PR description updated with the three points under "Main Changes" and "Verifying". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
