SebastianGruza commented on PR #3209: URL: https://github.com/apache/hugegraph/pull/3209#issuecomment-5704252204
Round 2 in bae56ca: DECIMAL values are bounded to 128 significant digits and an absolute scale of 128, checked in `valueToDecimal()` in both copies and, after removing the short-circuit in `PropertyKey.convValue()`, also for ready-made `BigDecimal`s (a Gremlin literal, the `SUM` result). The compatibility note now says that every `BigDecimal` in a response comes out as a string (V1, REST proxy) or as `gx:BigDecimal` with the string in `@value` (V2/V3). Locally on JDK 11: struct 5/5, unit 48/48 for the touched classes, core on rocksdb 339 tests in three classes with no failures, api on rocksdb green. E2E (`cluster/decimal_e2e.py`, now 41 checks with three new ones for the bound) on rocksdb with a dist from this head: 37 PASS, 0 FAIL, 4 N-A, log `results/decimal/e2e/after2-rocksdb.log` in hugegraph-validation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
