SebastianGruza commented on PR #3209: URL: https://github.com/apache/hugegraph/pull/3209#issuecomment-5768216260
New commit 0146849b, prompted by the review of the toolchain companion apache/hugegraph-toolchain#771: REST now reads JSON fractions as `BigDecimal` (`ObjectMapperResolver` registered next to `JacksonFeature`, `USE_BIG_DECIMAL_FOR_FLOATS`), so a DECIMAL value no longer has to be a string: the literal `12345678901234567890.123456789012345678` is stored exactly, a DOUBLE key narrows it as before, an INT key still rejects a fraction with the same message. `JsonUtil.castNumber` converts a BigDecimal to double instead of asserting on the JSON type. Tests: `testDecimalJsonNumberLiteralIsExact` plus a number literal as the increment in `testBatchUpdateDecimalWithSumStrategy`; `VertexApiTest` from the api-test profile on rocksdb 6/6 against this build. Blast radius checked: nothing in `hugegraph-api` assumes `Double` from JSON, the only place in core was `castNumber`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
