bitflicker64 commented on code in PR #3243:
URL: https://github.com/apache/hugegraph/pull/3243#discussion_r4164015975
##########
hugegraph-server/hugegraph-test/src/main/java/org/apache/hugegraph/core/VertexCoreTest.java:
##########
@@ -5187,7 +5187,7 @@ public void
testQueryByJointIndexesAndCompositeIndexForMultiLabel() {
this.mayCommitTx();
List<Vertex> vertices;
- vertices = graph().traversal().V().has("age", 3)
+ vertices = graph().traversal().V().hasLabel("dog", "cat").has("age", 3)
Review Comment:
Minor: With `hasLabel("dog", "cat")` the query is flattened into two
single-label queries, so this test no longer runs the unlabeled path where one
`collectMatchedIndexes()` call returns a composite plan for `dog` and a joint
plan for `cat`. That is the path `queryByUserprop()` changes here (all plans
validated first, then iterated), and no case in `SourceIndexCoverageTest` mixes
a composite and a joint plan in one unlabeled query (`testCompositeCoverage`
and `testJointIndexCoverage` each use one shape on both labels). Please keep
this query unlabeled and add compatible `age`/`city` indexes for the other
candidate labels in this test, or add an unlabeled mixed composite/joint case
to `SourceIndexCoverageTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
