imbajin commented on PR #3243: URL: https://github.com/apache/hugegraph/pull/3243#issuecomment-6191363696
Review of `15d87e19`: **8/10** after two independent source reviews and cross-checking. **P2 — Close earlier OR-branch cursors when coverage validation fails.** For a non-paged vertex `ConditionQuery` with `p='hit' OR q='hit'`, let labels A/B both declare p/q, index p on both, and index q only on A. `GraphTransaction.optimizeQueries()` eagerly opens the first branch’s index iterators, then the new `checkIndexCoverage()` rejects the second branch. The partially populated `QueryList` is abandoned before `fetch()` establishes cleanup ownership. On RocksDB, native cursors are already allocated; transaction rollback does not close them. This exposes an existing construction-cleanup gap through the new partial-coverage rejection path. Please close the accumulated `QueryList` when planning fails, preserving the original exception, and add an open/close-count regression. Relevant locations: `GraphTransaction.java:1517–1542`, `GraphIndexTransaction.java:403–404,588–591`, and `QueryList.java:87–117`. Source-confirmed finding, not a runtime reproduction. The previous visibility and mixed-index concerns are addressed in the current source; CI and full runtime acceptance remain separate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
