imbajin commented on code in PR #3243:
URL: https://github.com/apache/hugegraph/pull/3243#discussion_r4166647616
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/backend/tx/GraphIndexTransaction.java:
##########
@@ -797,6 +806,18 @@ private Set<MatchedIndex>
collectMatchedIndexes(ConditionQuery query) {
}
}
+ if (requireCompleteCoverage) {
+ // Match the public result visibility, including flattened queries.
+ // Removal jobs drop indexes before data/schema; those labels must
+ // neither require coverage nor contribute unavailable index plans.
+ // Cleanup callers still need to inspect invisible labels' indexes.
+ Query visibility = query.rootOriginQuery();
+ schemaLabels = schemaLabels.stream().filter(schemaLabel ->
Review Comment:
⚠️ Important: If the only candidate label for a valid property query is
hidden or deleting, this filter removes it and leaves `indexes` empty;
`queryByUserprop()` then throws `NoIndexException` at lines 483-486. Before
this change, the indexed result was filtered to an empty public result by
`GraphTransaction.invalidRecord()`. Please return an empty holder when every
candidate is excluded by visibility, while retaining `NoIndexException` for
visible candidates without usable indexes. Evidence: exact-head trace of these
methods and the result-visibility check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
