bitflicker64 commented on code in PR #509:
URL: https://github.com/apache/hugegraph-doc/pull/509#discussion_r4175218605
##########
content/en/docs/guides/hugegraph-docker-cluster.md:
##########
@@ -293,7 +293,16 @@ Standalone publishes only `8080` and `8088`; minimal
HStore publishes `8620` (PD
5. **Unexpected retained data**: `docker compose down` keeps named volumes. To
delete topology data too, use `docker compose down -v`.
-**Runtime logs**: `docker logs <container-name>` (for example, `docker logs
hg-pd0`) shows logs without entering containers. Standalone
`hugegraph/hugegraph` sets `STDOUT_MODE=true` and sends service logs to stdout.
The HStore `hugegraph/server` image does not set this variable: `docker logs`
shows only entrypoint output; inspect `logs/hugegraph-server.log` inside the
container for service logs.
+**Runtime logs**: `docker logs <container-name>` (for example, `docker logs
hg-pd0`) shows logs without entering containers. The PD, Store and both Server
Review Comment:
Important: The version note below says only the HStore `hugegraph/server`
image lacks `STDOUT_MODE` in 1.7.0, but the standalone
`hugegraph/hugegraph:1.7.0` image this page pins (see the standalone quick
start) does not set it either. `git grep STDOUT_MODE 1.7.0` in apache/hugegraph
returns nothing: `STDOUT_MODE` for PD, Store and Server came in c0a2b93e4
(#2980), which no release tag contains. In 1.7.0, `hugegraph-server.sh:186-188`
runs `exec java ... >> ${OUTPUT} 2>&1`, so `docker logs` on the standalone
container shows only entrypoint output. A reader following the 1.7.0 standalone
example gets the wrong answer from this paragraph and from the note. Please
widen the note to all 1.7.0 images, for example: "1.7.0 and older images,
including the standalone `hugegraph/hugegraph:1.7.0` above, do not set
`STDOUT_MODE`; read `logs/hugegraph-server.log` inside the container." Same
change in the CN page.
##########
content/cn/docs/guides/hugegraph-docker-cluster.md:
##########
@@ -293,7 +293,14 @@ curl -o /dev/null -w '%{http_code}\n' -u
"admin:${HUGEGRAPH_ADMIN_PASSWORD}" \
5. **数据在意料之外地保留了下来**：`docker compose down` 会保留命名卷。要同时删除该拓扑的数据，请使用 `docker
compose down -v`
-**查看运行时日志**：使用 `docker logs <container-name>`（如 `docker logs
hg-pd0`）可直接查看日志，无需进入容器。单机镜像 `hugegraph/hugegraph` 设置了
`STDOUT_MODE=true`，其服务日志会输出到容器 stdout。`hugegraph/server`（HStore）镜像没有设置该变量，因此对
HStore 拓扑的 Server 执行 `docker logs` 只能看到入口脚本的输出，其余内容需在容器内查看
`logs/hugegraph-server.log`。
+**查看运行时日志**：使用 `docker logs <container-name>`（如 `docker logs
hg-pd0`）可直接查看日志，无需进入容器。PD、Store 以及两个 Server 镜像（`hugegraph/hugegraph`
+和 HStore 的 `hugegraph/server`）都设置了 `STDOUT_MODE=true`，服务日志会输出到容器 stdout。对
Server 而言，Hadoop、ZooKeeper、SOFA、Netty 和 Commons 的 WARN
+及以上日志也会输出到 stdout；它们的 INFO 日志以及审计日志、慢查询日志仍只写入文件。完整的 `hugegraph-server.log`、JVM
崩溃日志（`hs_err_pid*.log`）和内存溢出
Review Comment:
Minor: This line breaks between `内存溢出` and `堆转储`. `hugo.yaml` has no
goldmark CJK `eastAsianLineBreaks` setting, so the soft break renders as a
space (`内存溢出 堆转储`) in Chromium. The same happens in
`content/cn/docs/quickstart/hugegraph/hugegraph-server.md` between `堆转储` and
`（java_pid...）`. Wrapping at 160 per AGENTS.md is fine; please move these
breaks to punctuation or next to a code span.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
