imbajin commented on code in PR #509: URL: https://github.com/apache/hugegraph-doc/pull/509#discussion_r4175650374
########## content/en/docs/quickstart/hugegraph/hugegraph-server.md: ########## @@ -535,6 +535,15 @@ This indicates the successful creation of the sample graph. `bin/stop-hugegraph.sh` accepts `-m true|false` (default `true`), which controls whether the cron monitor task is removed along with the service. +The server script always adds `-XX:+HeapDumpOnOutOfMemoryError`, `-XX:HeapDumpPath` and `-XX:ErrorFile`, so an out-of-memory heap dump +(`java_pid<pid>_<launch time>.hprof`) and a JVM crash log (`hs_err_pid<pid>_<launch time>.log`) land in `logs/` whether or not `JAVA_OPTIONS` is set. The +launch time keeps a restart that reuses the PID from colliding with an earlier file. A heap dump can be as large as the heap. To turn dumps off, pass +`-XX:-HeapDumpOnOutOfMemoryError` with `-j`, or in `JAVA_OPTIONS` if you set it (`-j` is ignored when `JAVA_OPTIONS` is set). A value given there for any of +these flags overrides the default, and a flag already set in `JAVA_TOOL_OPTIONS` or `JDK_JAVA_OPTIONS` is left as is. Review Comment: 🧹 Minor. Blocking: no. Summary: Please include _JAVA_OPTIONS in this sentence and the Chinese counterpart; it is processed after the launcher defaults and can override the heap-dump and crash-log paths too. Evidence: apache/hugegraph#3258's hugegraph-server.sh documents the precedence order, including _JAVA_OPTIONS after JAVA_TOOL_OPTIONS, JDK_JAVA_OPTIONS and command-line options. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
