byteayan commented on code in PR #509:
URL: https://github.com/apache/hugegraph-doc/pull/509#discussion_r4176122542
##########
content/en/docs/guides/hugegraph-docker-cluster.md:
##########
@@ -293,7 +293,16 @@ Standalone publishes only `8080` and `8088`; minimal
HStore publishes `8620` (PD
5. **Unexpected retained data**: `docker compose down` keeps named volumes. To
delete topology data too, use `docker compose down -v`.
-**Runtime logs**: `docker logs <container-name>` (for example, `docker logs
hg-pd0`) shows logs without entering containers. Standalone
`hugegraph/hugegraph` sets `STDOUT_MODE=true` and sends service logs to stdout.
The HStore `hugegraph/server` image does not set this variable: `docker logs`
shows only entrypoint output; inspect `logs/hugegraph-server.log` inside the
container for service logs.
+**Runtime logs**: `docker logs <container-name>` (for example, `docker logs
hg-pd0`) shows logs without entering containers. The PD, Store and both Server
Review Comment:
Fixed in 93e41d4f2. The paragraph now says stdout logging applies to images
built from current master, and the version note covers every 1.7.0 and older
image, including the standalone `hugegraph/hugegraph:1.7.0` used on this page.
It links #2980 and #3258 and says where service logs go instead. Chinese page
updated the same way.
##########
content/cn/docs/guides/hugegraph-docker-cluster.md:
##########
@@ -293,7 +293,14 @@ curl -o /dev/null -w '%{http_code}\n' -u
"admin:${HUGEGRAPH_ADMIN_PASSWORD}" \
5. **数据在意料之外地保留了下来**：`docker compose down` 会保留命名卷。要同时删除该拓扑的数据，请使用 `docker
compose down -v`
-**查看运行时日志**：使用 `docker logs <container-name>`（如 `docker logs
hg-pd0`）可直接查看日志，无需进入容器。单机镜像 `hugegraph/hugegraph` 设置了
`STDOUT_MODE=true`，其服务日志会输出到容器 stdout。`hugegraph/server`（HStore）镜像没有设置该变量，因此对
HStore 拓扑的 Server 执行 `docker logs` 只能看到入口脚本的输出，其余内容需在容器内查看
`logs/hugegraph-server.log`。
+**查看运行时日志**：使用 `docker logs <container-name>`（如 `docker logs
hg-pd0`）可直接查看日志，无需进入容器。PD、Store 以及两个 Server 镜像（`hugegraph/hugegraph`
+和 HStore 的 `hugegraph/server`）都设置了 `STDOUT_MODE=true`，服务日志会输出到容器 stdout。对
Server 而言，Hadoop、ZooKeeper、SOFA、Netty 和 Commons 的 WARN
+及以上日志也会输出到 stdout；它们的 INFO 日志以及审计日志、慢查询日志仍只写入文件。完整的 `hugegraph-server.log`、JVM
崩溃日志（`hs_err_pid*.log`）和内存溢出
Review Comment:
Fixed in 93e41d4f2: the new Chinese paragraphs on both pages now wrap only
at existing spaces next to code spans or Latin words, so no soft break falls
between two Chinese characters.
##########
content/en/docs/quickstart/hugegraph/hugegraph-server.md:
##########
@@ -535,6 +535,15 @@ This indicates the successful creation of the sample graph.
`bin/stop-hugegraph.sh` accepts `-m true|false` (default `true`), which
controls whether the cron monitor task is removed along with the service.
+The server script always adds `-XX:+HeapDumpOnOutOfMemoryError`,
`-XX:HeapDumpPath` and `-XX:ErrorFile`, so an out-of-memory heap dump
+(`java_pid<pid>_<launch time>.hprof`) and a JVM crash log
(`hs_err_pid<pid>_<launch time>.log`) land in `logs/` whether or not
`JAVA_OPTIONS` is set. The
+launch time keeps a restart that reuses the PID from colliding with an earlier
file. A heap dump can be as large as the heap. To turn dumps off, pass
+`-XX:-HeapDumpOnOutOfMemoryError` with `-j`, or in `JAVA_OPTIONS` if you set
it (`-j` is ignored when `JAVA_OPTIONS` is set). A value given there for any of
+these flags overrides the default, and a flag already set in
`JAVA_TOOL_OPTIONS` or `JDK_JAVA_OPTIONS` is left as is.
Review Comment:
Fixed in 93e41d4f2: the sentence (EN and CN) now lists `_JAVA_OPTIONS` with
the operator's `JAVA_TOOL_OPTIONS`, `JDK_JAVA_OPTIONS` and the command line as
sources read after the defaults. It also describes the move to
`JAVA_TOOL_OPTIONS` and the file-name counter from apache/hugegraph#3258.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
