imbajin commented on code in PR #378:
URL: https://github.com/apache/hugegraph-ai/pull/378#discussion_r4186771641
##########
hugegraph-llm/src/hugegraph_llm/demo/rag_demo/configs_block.py:
##########
@@ -779,6 +795,31 @@ def vector_engine_settings(engine):
apply_faiss_button = gr.Button("Apply Configuration")
apply_faiss_button.click(lambda: apply_vector_engine(engine))
+ def refresh_llm_config(revision):
+ with runtime_config_lock:
+ llm_settings.__init__() # type: ignore[misc] # pylint:
disable=C2801
Review Comment:
⚠️ Blocking: no. Summary: Refreshing after removing a previously configured
key can restore its stale value and write it back to .env. Please reload
without retaining values copied from earlier .env contents, and cover key
removal in the regression test. Evidence: BaseConfig.__init__ copies .env
entries into os.environ without clearing entries absent on later loads;
check_env() then writes missing model fields back to the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
