JesusMan0529 commented on code in PR #378:
URL: https://github.com/apache/hugegraph-ai/pull/378#discussion_r4194571391
##########
hugegraph-llm/src/hugegraph_llm/config/models/base_config.py:
##########
@@ -150,15 +162,9 @@ def _sync_object_to_env(self, env_config, config_dict):
def __init__(self, **data):
try:
file_exists = os.path.exists(env_path)
- # Step 1: Load environment variables if file exists
- if file_exists:
- env_config = dotenv_values(env_path)
- for k, v in env_config.items():
- os.environ[k] = v
-
- # Step 2: Init the parent class with loaded environment variables
+ # Load and validate settings directly from the current sources.
Review Comment:
Fixed in 76a8ea0. The .env-only write opt-in now works for both endpoints
without exporting it into the process environment. Added production-router
tests for authentication, source precedence and removing the flag. Also checked
the other standalone file settings and preserved their dotenv support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
