bitflicker64 commented on code in PR #784:
URL:
https://github.com/apache/hugegraph-toolchain/pull/784#discussion_r4199145956
##########
.github/workflows/ci.yml:
##########
@@ -85,10 +85,9 @@ jobs:
if: steps.scope.outputs.needsFixture == 'true'
uses: ./.github/actions/get-hugegraph-commit
with:
- # TODO(apache/hugegraph#3263): switch the temporary source to ASF
after merge.
- repository: hugegraph/hugegraph
- ref: codex/cypher-minimal-compat
- expected-commit: 4c162f539b906fa06dd83228e3691b77fa5b77d7
+ repository: apache/hugegraph
+ ref: master
Review Comment:
Important: `ref: master` together with `expected-commit: d9abcd4...` breaks
as soon as apache/hugegraph master moves. `get-hugegraph-commit/resolve.cjs`
resolves `master` to the current tip and throws `Server ref moved` when it
differs from the expected SHA. `checkout-server.sh` does the same thing: it
fetches `SERVER_FETCH_REF` with `--depth 1` and exits on `Server checkout
mismatch`. Today master is exactly d9abcd4 (`compare d9abcd4...master` returns
`identical`), which is the only reason CI is green. After the next unrelated
Server commit, this plan step fails, and so do `setup-candidate-sdk` (its
default `ref` is now `master`), the `java17-images-ci.yml` job, and every
direct `docker build` of `hugegraph-loader/Dockerfile` and
`hugegraph-hubble/Dockerfile`. That includes builds from a released Toolchain
source tree, which can never be fixed later. The old
`codex/cypher-minimal-compat` branch was frozen, so it did not have this
problem.
Please fetch the pinned commit itself rather than a moving branch. GitHub
serves shallow fetches by SHA: `git fetch --depth 1 origin
d9abcd4317fb36128e7e4d209139ec7f3a28cdfc` against apache/hugegraph works, and
`getCommit` accepts a SHA as `ref`. Concretely: use `ref:
d9abcd4317fb36128e7e4d209139ec7f3a28cdfc` here and in `java17-images-ci.yml`;
make it the `ref` default in `setup-candidate-sdk/action.yml`; and in both
Dockerfiles and `docs/java17-migration.md`, drop `SERVER_FETCH_REF=master`
(checkout-server.sh already defaults the fetch ref to the commit). The lock
stays fail-closed, and advancing the baseline remains a deliberate edit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
