imbajin commented on code in PR #784: URL: https://github.com/apache/hugegraph-toolchain/pull/784#discussion_r4215086586
########## .github/workflows/upstream-compatibility.yml: ########## @@ -0,0 +1,85 @@ +name: Upstream compatibility + +on: + schedule: + - cron: '17 3 * * *' + workflow_dispatch: + pull_request: + paths: + - '.github/workflows/upstream-compatibility.yml' + - '.github/actions/get-hugegraph-commit/**' + - '.github/actions/setup-candidate-sdk/**' + - 'hugegraph-client/assembly/travis/install-candidate-sdk.sh' + - 'hugegraph-client/assembly/travis/checkout-server.sh' + - '.github/scripts/verify_candidate_image_sdk.py' Review Comment: ⚠️ Blocking: no. Summary: This workflow consumes the local setup-java-env action (which supplies Maven's settings file) and runs start-hugegraph-servers.sh, but none of those paths is in pull_request.paths. A change to either action, .github/configs/settings.xml, or the server startup script can therefore skip this current-master compatibility gate; please add all three paths. Evidence: workflow steps 32–36 and 58–61; setup-java-env exports --settings .github/configs/settings.xml through MAVEN_ARGS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
