imbajin commented on code in PR #784:
URL:
https://github.com/apache/hugegraph-toolchain/pull/784#discussion_r4202060042
##########
hugegraph-client/assembly/travis/install-candidate-sdk.sh:
##########
@@ -36,15 +36,22 @@ export PATH="$JAVA_HOME/bin:$PATH"
SCRIPT_DIR=$(cd "$(dirname "$0")" && pwd)
SOURCE_DIR=$2
-# TODO(apache/hugegraph#3263): temporary pre-merge source; after merge use
apache/hugegraph and a verified ASF SHA.
-SERVER_REPOSITORY=${SERVER_REPOSITORY:-hugegraph/hugegraph}
+SERVER_REPOSITORY=${SERVER_REPOSITORY:-apache/hugegraph}
SERVER_FETCH_REF=${SERVER_FETCH_REF:-$1}
export SERVER_REPOSITORY SERVER_FETCH_REF
CANDIDATE_REPO=$3
bash "$SCRIPT_DIR/checkout-server.sh" "$1" "$SOURCE_DIR"
-# Install the entire locked reactor so Common, Core, PD and Store share one
source.
+# Install the SDK and Server distribution dependency closure from one source.
+# Server cluster tests pull an unrelated released Toolchain/SDK back into this
build.
# The fixture installers retain package-only semantics and use another
repository.
-(cd "$SOURCE_DIR" && mvn "-Dmaven.repo.local=$CANDIDATE_REPO" install \
+SDK_MODULES=hugegraph-server/hugegraph-dist,hugegraph-pd/hg-pd-client
+SDK_MODULES+=,hugegraph-store/hg-store-client,hugegraph-struct
+# Flatten the root too: its installed ${revision} otherwise breaks dependency
+# model reconstruction while remote-resources generates license metadata.
+(cd "$SOURCE_DIR" && mvn "-Dmaven.repo.local=$CANDIDATE_REPO" \
+ -pl "$SDK_MODULES" -am \
Review Comment:
🧹 Blocking: no. Summary: The helper now builds four selected projects plus
their dependencies, while docs/java17-migration.md still says it installs the
complete locked server reactor. Please update the guide to describe the
narrowed module selection so users do not expect unrelated server modules in
candidate_repo. Evidence: SDK_MODULES lists hugegraph-server/hugegraph-dist,
hugegraph-pd/hg-pd-client, hugegraph-store/hg-store-client, and
hugegraph-struct before Maven runs with -pl and -am.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
