imbajin commented on code in PR #3290:
URL: https://github.com/apache/hugegraph/pull/3290#discussion_r4213601458
##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/cypher/CypherAPI.java:
##########
@@ -159,7 +159,7 @@ private Pair<String, String> toUserPass(String auth) {
String encoded = auth.substring(basic.length());
byte[] userPass = this.decoder.decode(encoded);
String authorization = new String(userPass, UTF8);
- split = authorization.split(":");
+ split = authorization.split(":", 2);
Review Comment:
⚠️ Blocking: no. Summary: This changes Cypher's independent Basic-credential
parser, but the new regression test exercises only the REST graphs endpoint.
Please add a Cypher endpoint test using a colon-containing password so
regressions in this path are covered. Evidence: LoginApiTest covers REST only,
and exact-head CypherApiTest has no Basic-auth case; the PR description reports
a manual Cypher check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
