arshilkxwork commented on code in PR #3290:
URL: https://github.com/apache/hugegraph/pull/3290#discussion_r4240283699
##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/cypher/CypherAPI.java:
##########
@@ -221,7 +221,7 @@ private Pair<String, String> toUserPass(String auth) {
String encoded = auth.substring(basic.length());
byte[] userPass = this.decoder.decode(encoded);
Review Comment:
Confirmed, and thank you for the probes. Commit 7e048d1 replaces the decoder
with `Base64.getDecoder()`, consistent with `WsAndHttpBasicAuthHandler`.
`testBasicAuthWithColonPassword` now covers three passwords for
`cypher_colon_user`: `a:b:c`, `a:b:c~` and `a:b:c?`. The latter two produce
headers ending in `+` and `/`. The test asserts this first, so renaming the
user cannot silently remove that coverage. Each password must return the query
result, and an incorrect password must receive 401. With `getUrlDecoder()`
restored, the test fails with the same 500 response you reported.
Regarding HStore, the new test did fail there. Its setup creates the group
through `auth/groups`, whereas in PD mode groups are scoped to a graphspace, so
creating the access returned 403 ("group belongs to another graphspace"). This
caused the `pd_store / hstore` failure at 577f4c3. The test now calls
`assumeStandaloneMode()`, as `testSpecifiedGraphRouting` does. The parsing it
covers is independent of the backend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
