arshilkxwork commented on PR #3290: URL: https://github.com/apache/hugegraph/pull/3290#issuecomment-6105522314
Thank you for the review. Commit 7e048d1 switches `CypherAPI` to the standard Base64 decoder and adds both suggested cases (`...OmN+` and `...OmM/`) to the Cypher test, each with a wrong-password check. The details are in the inline thread. The parsing remains in `CypherAPI` and is not shared with the filter. The same commit addresses the `pd_store / hstore` failure at 577f4c3, which was caused by the new test. Its group setup applies only to standalone mode, so the test is now skipped on HStore. Local results at 7e048d1: the full api-test suite passes on RocksDB (182 tests, 14 skipped) and on HStore with PD and Store started by `install-backend.sh` (176 tests, 52 skipped). Unit tests pass except four cases in `RocksDBSnapshotRestoreTest`, which fail on macOS because `/var` resolves to `/private/var`. This PR does not modify that code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
