bitflicker64 commented on code in PR #523: URL: https://github.com/apache/hugegraph-doc/pull/523#discussion_r4254176827
########## content/en/docs/config/config-backend-hstore.md: ########## @@ -246,3 +246,17 @@ curl http://localhost:8080/metrics/backend The `nodes` value in the response is the count of active stores PD returns. A `nodes` value of `0` means the Server reached PD but PD has no store in state `Up`, which usually means the Store nodes have not registered yet, or registered as `Pending` because they are not in PD's `pd.initial-store-list`. + +Store builds containing the legacy GraphID preflight check existing graph-data column families before allocating a missing graph ID, first opening a cold Review Comment: Minor: the new text is appended to `### 8 Verification` directly after the `nodes` metrics explanation, with no heading of its own (same on line 212 of the Chinese page). Evidence: at this head the last heading in the page is `### 8 Verification` (line 237), and its content is the post-configuration `curl` checks. The upgrade refusal and evidence-preservation guidance is a different topic, has no anchor to link to from release notes or an error message, and does not show up in the page outline. Requested change: put it under its own heading in both languages, for example `### 9 Legacy GraphID upgrade preflight` / `### 9 旧 GraphID 升级预检`. ########## content/en/docs/config/config-backend-hstore.md: ########## @@ -246,3 +246,17 @@ curl http://localhost:8080/metrics/backend The `nodes` value in the response is the count of active stores PD returns. A `nodes` value of `0` means the Server reached PD but PD has no store in state `Up`, which usually means the Store nodes have not registered yet, or registered as `Pending` because they are not in PD's `pd.initial-store-list`. + +Store builds containing the legacy GraphID preflight check existing graph-data column families before allocating a missing graph ID, first opening a cold +partition DB during metadata bootstrap, starting its Raft state machine, or activating a staged snapshot. Before pruning, the first cold DB open checks +all retained valid versions. Reserved `FFFE` legacy rows cause refusal. +An incomplete selected DB version without `CURRENT` is also rejected when it would hide retained valid versions. This concerns affected old write paths; +it does not mean that every 1.7 database needs migration, and the persisted ID format is unchanged. + +On refusal, preserve the original data DB versions, metadata, WAL and incoming/staged snapshots. Investigate the affected write and upgrade history before +resuming writes or replay. Do not delete graph-to-ID mappings or assign all reserved-prefix rows to one graph: different graphs may share that prefix. +Store/Raft location metadata may already have been updated before the check, so the entire bootstrap is not read-only. The check performs no automatic +migration or ownership repair; a complete 1.7 upgrade and recovery still require deployment-specific validation. + +See the [preflight change](https://github.com/hugegraph/hugegraph/pull/301) and the Review Comment: Important: these paragraphs describe a Store refusal that no apache/hugegraph build performs yet, and both references point at an unmerged PR in the `hugegraph/hugegraph` fork. Evidence: on apache/hugegraph master (2ae73704c) `git grep -n "checkLegacyGraphIdData\|resolveExistingDBPath\|store-graphid"` returns nothing, and `docs/store-graphid-upgrade.md` does not exist there. The check lives only in hugegraph/hugegraph#301, which is still open at 27731930, and a search of apache/hugegraph finds no matching PR. The same two links are on lines 221-222 of `content/cn/docs/config/config-backend-hstore.md`. Once this is published on hugegraph.apache.org, an operator on 1.7.0 or current master who has reserved-prefix rows will read that Store refuses before allocating a graph ID, while their build allocates and continues. "Store builds containing the legacy GraphID preflight" gives them no way to tell which builds those are. Requested change: hold this until the implementation is merged in apache/hugegraph, then name the first release that contains it and link the apache PR and the guide on apache master. If it has to land earlier, state in both pages that the check is not in any Apache release yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
